Re: [PATCH 5/9] efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table

From: Matt Fleming
Date: Mon Nov 14 2016 - 09:02:59 EST


On Mon, 14 Nov, at 02:55:22PM, Ingo Molnar wrote:
>
> The problem is not that Ard applied the patches, but that you subsequently rebased
> the tree. For example:
>
> commit bf5d1f98c1d8be04a40eabb9dd6913347b1b3fc4
> Author: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> AuthorDate: Thu Oct 20 12:21:26 2016 +0100
> Commit: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>
> CommitDate: Sat Nov 12 21:14:41 2016 +0000
>
> efi/arm*: libstub: Invoke EFI_RNG_PROTOCOL to seed the UEFI RNG table
>
> Invoke the EFI_RNG_PROTOCOL protocol in the context of the stub and
> install the Linux-specific RNG seed UEFI config table. This will be
> picked up by the EFI routines in the core kernel to seed the kernel
> entropy pool.
>
> Cc: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>

Ah yes, this is exactly what happened.

> if you rebase it (with your co-maintainer's permission) then you need to add your
> SoB tag.

OK, will do so in future. Thanks Ingo.