Re: [PATCH 00/29] UBIFS File Encryption v1

From: Richard Weinberger
Date: Mon Nov 14 2016 - 07:01:26 EST


Ted,

On 14.11.2016 04:05, Theodore Ts'o wrote:
> Richard,
>
> Your fscrypt patches look good. I've created an fscrypt branch on the
> ext4.git tree which contains your changes as well as Eric Bigger's
> recent fspatch cleanups changes. If you want to base your ubifs
> changes on that branch, that would be great. The ext4 dev branch will
> be including that fscrypt branch, so it will be feeding into
> linux-next that way. If you also base your patches on that, it will
> avoid duplicate patches in linux-next and in Linus's tree when he
> pulls them.

Will do!

> One quick question. When ubifs uses subpage blocks, can you assume that
> they are always powers of two? Or more to the point, can you assume
> that it will always be a multiple of the cipher's blocksize?

Yes, UBIFS takes care about that. Subpage blocks are always a multiple of
FS_CRYPTO_BLOCK_SIZE.

Thanks,
//richard