Re: [PATCH 01/11] mtd: nand: denali: remove unneeded <linux/slab.h> includes

From: Marek Vasut
Date: Sat Nov 12 2016 - 16:58:37 EST


On 11/09/2016 05:35 AM, Masahiro Yamada wrote:
> The driver calls devm_kzalloc()/devm_kfree() to allocate/free memory.
> They are declared in <linux/device.h>, not in <linux/slab.h>.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>

Reviewed-by: Marek Vasut <marek.vasut@xxxxxxxxx>

> ---
>
> drivers/mtd/nand/denali.c | 1 -
> drivers/mtd/nand/denali_dt.c | 1 -
> drivers/mtd/nand/denali_pci.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> index 7e2c650..062d5b5 100644
> --- a/drivers/mtd/nand/denali.c
> +++ b/drivers/mtd/nand/denali.c
> @@ -21,7 +21,6 @@
> #include <linux/dma-mapping.h>
> #include <linux/wait.h>
> #include <linux/mutex.h>
> -#include <linux/slab.h>
> #include <linux/mtd/mtd.h>
> #include <linux/module.h>
>
> diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c
> index f821dc1..5607fcd 100644
> --- a/drivers/mtd/nand/denali_dt.c
> +++ b/drivers/mtd/nand/denali_dt.c
> @@ -21,7 +21,6 @@
> #include <linux/platform_device.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> -#include <linux/slab.h>
>
> #include "denali.h"
>
> diff --git a/drivers/mtd/nand/denali_pci.c b/drivers/mtd/nand/denali_pci.c
> index de31514..ac84323 100644
> --- a/drivers/mtd/nand/denali_pci.c
> +++ b/drivers/mtd/nand/denali_pci.c
> @@ -14,7 +14,6 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/pci.h>
> -#include <linux/slab.h>
>
> #include "denali.h"
>
>


--
Best regards,
Marek Vasut