Re: [PATCH] shmem: avoid huge pages for small files

From: kbuild test robot
Date: Thu Nov 10 2016 - 12:43:45 EST


Hi Kirill,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.9-rc4 next-20161110]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Kirill-A-Shutemov/shmem-avoid-huge-pages-for-small-files/20161111-005428
config: i386-randconfig-s0-201645 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All warnings (new ones prefixed by >>):

mm/shmem.c: In function 'shmem_getpage_gfp':
>> mm/shmem.c:1680:12: warning: unused variable 'off' [-Wunused-variable]
pgoff_t off;
^~~

vim +/off +1680 mm/shmem.c

66d2f4d2 Hugh Dickins 2014-07-02 1664 mark_page_accessed(page);
66d2f4d2 Hugh Dickins 2014-07-02 1665
54af6042 Hugh Dickins 2011-08-03 1666 delete_from_swap_cache(page);
27ab7006 Hugh Dickins 2011-07-25 1667 set_page_dirty(page);
27ab7006 Hugh Dickins 2011-07-25 1668 swap_free(swap);
27ab7006 Hugh Dickins 2011-07-25 1669
54af6042 Hugh Dickins 2011-08-03 1670 } else {
800d8c63 Kirill A. Shutemov 2016-07-26 1671 /* shmem_symlink() */
800d8c63 Kirill A. Shutemov 2016-07-26 1672 if (mapping->a_ops != &shmem_aops)
800d8c63 Kirill A. Shutemov 2016-07-26 1673 goto alloc_nohuge;
657e3038 Kirill A. Shutemov 2016-07-26 1674 if (shmem_huge == SHMEM_HUGE_DENY || sgp_huge == SGP_NOHUGE)
800d8c63 Kirill A. Shutemov 2016-07-26 1675 goto alloc_nohuge;
800d8c63 Kirill A. Shutemov 2016-07-26 1676 if (shmem_huge == SHMEM_HUGE_FORCE)
800d8c63 Kirill A. Shutemov 2016-07-26 1677 goto alloc_huge;
800d8c63 Kirill A. Shutemov 2016-07-26 1678 switch (sbinfo->huge) {
800d8c63 Kirill A. Shutemov 2016-07-26 1679 loff_t i_size;
800d8c63 Kirill A. Shutemov 2016-07-26 @1680 pgoff_t off;
800d8c63 Kirill A. Shutemov 2016-07-26 1681 case SHMEM_HUGE_NEVER:
800d8c63 Kirill A. Shutemov 2016-07-26 1682 goto alloc_nohuge;
800d8c63 Kirill A. Shutemov 2016-07-26 1683 case SHMEM_HUGE_WITHIN_SIZE:
bb89f249 Kirill A. Shutemov 2016-11-10 1684 i_size = i_size_read(inode);
bb89f249 Kirill A. Shutemov 2016-11-10 1685 if (index >= HPAGE_PMD_NR || i_size >= HPAGE_PMD_SIZE)
800d8c63 Kirill A. Shutemov 2016-07-26 1686 goto alloc_huge;
800d8c63 Kirill A. Shutemov 2016-07-26 1687 /* fallthrough */
800d8c63 Kirill A. Shutemov 2016-07-26 1688 case SHMEM_HUGE_ADVISE:

:::::: The code at line 1680 was first introduced by commit
:::::: 800d8c63b2e989c2e349632d1648119bf5862f01 shmem: add huge pages support

:::::: TO: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip