RE: [v16, 0/7] Fix eSDHC host version register bug

[Y.B. Lu]

> -----Original Message-----
> From: linux-mmc-owner@xxxxxxxxxxxxxxx [mailto:linux-mmc-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Scott Wood
> Sent: Thursday, November 10, 2016 11:55 AM
> To: Ulf Hansson; Y.B. Lu
> Cc: linux-mmc; Arnd Bergmann; linuxppc-dev@xxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-clk; iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; Greg Kroah-Hartman; Mark Rutland; Rob Herring;
> Russell King; Jochen Friedrich; Joerg Roedel; Claudiu Manoil; Bhupesh
> Sharma; Qiang Zhao; Kumar Gala; Leo Li; X.B. Xie; M.H. Lian
> Subject: Re: [v16, 0/7] Fix eSDHC host version register bug
> 
> On Wed, 2016-11-09 at 19:27 +0100, Ulf Hansson wrote:
> > - i2c-list
> >
> > On 9 November 2016 at 04:14, Yangbo Lu <yangbo.lu@xxxxxxx> wrote:
> > >
> > > This patchset is used to fix a host version register bug in the
> > > T4240-
> > > R1.0-R2.0
> > > eSDHC controller. To match the SoC version and revision, 15 previous
> > > version patchsets had tried many methods but all of them were
> > > rejected by reviewers.
> > > Such as
> > > ÂÂÂÂÂÂÂÂ- dts compatible method
> > > ÂÂÂÂÂÂÂÂ- syscon method
> > > ÂÂÂÂÂÂÂÂ- ifdef PPC method
> > > ÂÂÂÂÂÂÂÂ- GUTS driver getting SVR method Anrd suggested a
> > > soc_device_match method in v10, and this is the only available
> > > method left now. This v11 patchset introduces the soc_device_match
> > > interface in soc driver.
> > >
> > > The first four patches of Yangbo are to add the GUTS driver. This is
> > > used to register a soc device which contain soc version and revision
> > > information.
> > > The other three patches introduce the soc_device_match method in soc
> > > driver and apply it on esdhc driver to fix this bug.
> > >
> > > ---
> > > Changes for v15:
> > > ÂÂÂÂÂÂÂÂ- Dropped patch 'dt: bindings: update Freescale DCFG
> compatible'
> > > ÂÂÂÂÂÂÂÂÂÂsince the work had been done by below patch on ShawnGuo's
> > > linux tree.
> > > ÂÂÂÂÂÂÂÂÂÂ'dt-bindings: fsl: add LS1043A/LS1046A/LS2080A compatible
> > > for SCFG
> > > ÂÂÂÂÂÂÂÂÂÂÂand DCFG'
> > > ÂÂÂÂÂÂÂÂ- Fixed error code issue in guts driver Changes for v16:
> > > ÂÂÂÂÂÂÂÂ- Dropped patch 'powerpc/fsl: move mpc85xx.h to
> include/linux/fsl'
> > > ÂÂÂÂÂÂÂÂ- Added a bug-fix patch from Geert
> > > ---
> > >
> > > Arnd Bergmann (1):
> > > Â base: soc: introduce soc_device_match() interface
> > >
> > > Geert Uytterhoeven (1):
> > > Â base: soc: Check for NULL SoC device attributes
> > >
> > > Yangbo Lu (5):
> > > Â ARM64: dts: ls2080a: add device configuration node
> > > Â dt: bindings: move guts devicetree doc out of powerpc directory
> > > Â soc: fsl: add GUTS driver for QorIQ platforms
> > > Â MAINTAINERS: add entry for Freescale SoC drivers
> > > Â mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0
> > >
> > > Â.../bindings/{powerpc => soc}/fsl/guts.txtÂÂÂÂÂÂÂÂÂ|ÂÂÂ3 +
> > > ÂMAINTAINERSÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ11 +-
> > > Âarch/arm64/boot/dts/freescale/fsl-ls2080a.dtsiÂÂÂÂÂ|ÂÂÂ6 +
> > > Âdrivers/base/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ1 +
> > > Âdrivers/base/soc.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ70 ++++++
> > > Âdrivers/mmc/host/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ1 +
> > > Âdrivers/mmc/host/sdhci-of-esdhc.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ20 ++
> > > Âdrivers/soc/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ3 +-
> > > Âdrivers/soc/fsl/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ18 ++
> > > Âdrivers/soc/fsl/MakefileÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ1 +
> > > Âdrivers/soc/fsl/guts.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 236
> > > +++++++++++++++++++++
> > > Âinclude/linux/fsl/guts.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 125
> > > ++++++-----
> > > Âinclude/linux/sys_soc.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ3 +
> > > Â13 files changed, 447 insertions(+), 51 deletions(-)
> > > Ârename Documentation/devicetree/bindings/{powerpc =>
> > > soc}/fsl/guts.txt
> > > (91%)
> > > Âcreate mode 100644 drivers/soc/fsl/Kconfig
> > > Âcreate mode 100644 drivers/soc/fsl/guts.c
> > >
> > > --
> > > 2.1.0.27.g96db324
> > >
> > Thanks, applied on my mmc tree for next!
> >
> > I noticed that some DT compatibles weren't documented, according to
> > checkpatch. Please fix that asap!
> 
> They are documented, in fsl/guts.txt (the file moved in patch 2/7):
> > Â- compatible : Should define the compatible device type for
> > ÂÂÂglobal-utilities.
> > ÂÂÂPossible compatibles:
> > ÂÂÂÂÂÂÂÂ"fsl,qoriq-device-config-1.0"
> > ÂÂÂÂÂÂÂÂ"fsl,qoriq-device-config-2.0"
> > ÂÂÂÂÂÂÂÂ"fsl,<chip>-device-config"
> > ÂÂÂÂÂÂÂÂ"fsl,<chip>-guts"
> 
> Checkpatch doesn't understand compatibles defined in such a way.

[Lu Yangbo-B47093] You're right, Scott. I dropped DT patch 'dt: bindings: update Freescale DCFG compatible '
which fixed un-doc issue since Shaohui had done this on Shawn Guo's tree.
https://git.kernel.org/cgit/linux/kernel/git/shawnguo/linux.git/commit/?h=imx/dt64&id=981034a2bfcaff5c95dafde24d7abfe7f9025c19

Thanks.

> 
> -Scott
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at
> http://vger.kernel.org/majordomo-info.html