Re: [PATCH 1/2] skd: fix msix error handling

From: Jens Axboe
Date: Thu Nov 10 2016 - 00:54:42 EST


On 11/09/2016 05:55 AM, Arnd Bergmann wrote:
As reported by gcc -Wmaybe-uninitialized, the cleanup path for
skd_acquire_msix tries to free the already allocated msi-x vectors
in reverse order, but the index variable may not have been
used yet:

drivers/block/skd_main.c: In function âskd_acquire_irqâ:
drivers/block/skd_main.c:3890:8: error: âiâ may be used uninitialized in this function [-Werror=maybe-uninitialized]

This changes the failure path to skip releasing the interrupts
if we have not started requesting them yet.

Applied both patches, thanks Arnd.

--
Jens Axboe