Re: [PATCH 1/2] wcn36xx: Correct Kconfig dependency

From: Marcel Holtmann
Date: Wed Nov 09 2016 - 15:32:25 EST


Hi Bjorn,

> In the case SMD or WCNSS_CTRL are compiled as modules, wcn36xx must be
> compiled as module as well, so we need to mention this dependency.
> But we still want allow the driver to be compiled in case either of
> those are =n, for compile testing reasons.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> ---
> drivers/net/wireless/ath/wcn36xx/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/Kconfig b/drivers/net/wireless/ath/wcn36xx/Kconfig
> index 591ebaea8265..4b83e87f0b94 100644
> --- a/drivers/net/wireless/ath/wcn36xx/Kconfig
> +++ b/drivers/net/wireless/ath/wcn36xx/Kconfig
> @@ -1,6 +1,8 @@
> config WCN36XX
> tristate "Qualcomm Atheros WCN3660/3680 support"
> depends on MAC80211 && HAS_DMA
> + depends on QCOM_WCNSS_CTRL || QCOM_WCNSS_CTRL=n
> + depends on QCOM_SMD || QCOM_SMD=n

I thought we wanted to move towards being able to compile the WiFi and Bluetooth support without requiring QCOM_SMD.

Regards

Marcel