Re: [PATCH] clk: pxa: Use __iomem properly and staticize lock variable

From: Robert Jarzmik
Date: Wed Nov 09 2016 - 15:18:10 EST


Stephen Boyd <sboyd@xxxxxxxxxxxxxx> writes:

> This function is passed an __iomem pointer but we use a u32
> pointer instead which makes checkers like spare complain.
> Furthermore, "lock" is a pretty poor variable name for a string
> that will go into lockdep reports and the symbol isn't marked
> static. Cleanup all this.
>
> Cc: Robert Jarzmik <robert.jarzmik@xxxxxxx>
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
Most certainly.

Acked-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>

Cheers.

--
Robert