Re: [PATCH V2 3/5] arm64: hw_breakpoint: Handle inexact watchpoint addresses

From: Pratyush Anand
Date: Wed Nov 09 2016 - 12:39:22 EST




On Tuesday 08 November 2016 05:28 PM, Pavel Labath wrote:
+ if (min_dist > 0 && min_dist != -1) {
>> + /* No exact match found. */
>> + wp = slots[closest_match];
>> + info = counter_arch_bp(wp);
>> + info->trigger = addr;
>> + perf_bp_event(wp, regs);
>> + }
>
> Why don't we need to bother with the stepping in the case of a non-exact
> match?
Good catch. I think we do. I must have dropped that part somehow.

Pratyush, could you include the attached fixup in the next batch?

Ok, will do.

~Pratyush