Re: [PATCH 1/4] x86/cpufeature: Add User-Mode Instruction Prevention definitions

From: Ricardo Neri
Date: Tue Nov 08 2016 - 23:25:40 EST


On Tue, 2016-11-08 at 07:32 -0800, Andy Lutomirski wrote:
> > diff --git a/arch/x86/include/asm/disabled-features.h
> b/arch/x86/include/asm/disabled-features.h
> > index 85599ad..4707445 100644
> > --- a/arch/x86/include/asm/disabled-features.h
> > +++ b/arch/x86/include/asm/disabled-features.h
> > @@ -16,6 +16,12 @@
> > # define DISABLE_MPX (1<<(X86_FEATURE_MPX & 31))
> > #endif
> >
> > +#ifdef CONFIG_X86_INTEL_UMIP
>
> ^^^^^
>
> What's this?
>
> Let's try to do this with a minimum of configuration.

My intention here is put in this file all the #if build configurations
so that I don't have to put them other files by using functions such as
cpu_feature_enable. Isn't this the intention of this file?

Thanks and BR,
Ricardo