Re: [RFC][ATCH 3/3] syscalls: Remove start and number from syscall_get_arguments() args

From: Steven Rostedt
Date: Tue Nov 08 2016 - 14:22:06 EST


On Mon, 7 Nov 2016 15:54:14 -0800
Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:

> On Mon, Nov 7, 2016 at 1:26 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > From: Steven Rostedt <rostedt@xxxxxxxxxxx>
> >
>
> > diff --git a/arch/x86/include/asm/syscall.h b/arch/x86/include/asm/syscall.h
> > index e3c95e8e61c5..050891169b51 100644
> > --- a/arch/x86/include/asm/syscall.h
> > +++ b/arch/x86/include/asm/syscall.h
>
> x86 part is:
>
> Reviewed-by: Andy Lutomirski <luto@xxxxxxxxxx>
>
> Although I wonder why this takes a task argument.

Thanks, although kbuild bot discovered a slight mistake:

} else {
# endif
*args++ = regs->di;

Should be:

} else
# endif
{
*args++ = regs->di;

I'll update, and also look at making it a struct.

-- Steve