Re: [PATCH v3 2/4] kconfig: regenerate *.c_shipped files after previous changes

From: Josh Triplett
Date: Mon Nov 07 2016 - 18:12:49 EST


On Mon, Nov 07, 2016 at 05:41:38PM -0500, Nicolas Pitre wrote:
> On Mon, 7 Nov 2016, Josh Triplett wrote:
>
> > [snipping large patch]
> >
> > One suggestion that might make this patch easier to review: you might
> > consider first regenerating the unchanged parser with Bison 3.0.4, then
> > regenerating it again after the "imply" change. I think that'd
> > eliminate quite a lot of noise in this patch.
>
> I tried that. This made two large patches instead of just one, both
> equally obscure.
>
> So this patch stands on its own, containing changes that are
> mechanically generated and therefore shouldn't require manual review.

Fair enough. I hadn't expected that the changes from "imply" would still
be huge.