Re: [PATCH 20/25] x86/mcheck: Be prepared for a rollback back to the ONLINE state

From: Borislav Petkov
Date: Mon Nov 07 2016 - 07:31:41 EST


On Mon, Nov 07, 2016 at 11:40:55AM +0100, Sebastian Andrzej Siewior wrote:
> On 2016-11-07 11:32:19 [+0100], Borislav Petkov wrote:
> > On Thu, Nov 03, 2016 at 03:50:16PM +0100, Sebastian Andrzej Siewior wrote:
> > > If we try a CPU down and fail in the middle then we roll back to the
> > > online state. This means we would perform CPU_ONLINE()
> > > without invoking CPU_DEAD() for the cleanup of what was allocated in
> >
> > Are CPU_ONLINE() and CPU_DEAD() functions? Those are the states, right?
>
> those are states. I meant here the driver specific function invoked in
> those states.

Yeah, so say that please - slapping "()" after the state name doesn't
make it clear.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.