Re: [PATCH v2] staging: lustre: mdc: manage number of modify RPCs in flight

From: Greg Kroah-Hartman
Date: Mon Nov 07 2016 - 05:38:37 EST


On Wed, Nov 02, 2016 at 02:46:52PM -0400, James Simmons wrote:
> From: Gregoire Pichon <gregoire.pichon@xxxxxxxx>
>
> This patch is the main client part of a new feature that supports
> multiple modify metadata RPCs in parallel. Its goal is to improve
> metadata operations performance of a single client, while maintening
> the consistency of MDT reply reconstruction and MDT recovery
> mechanisms.
>
> It allows to manage the number of modify RPCs in flight within
> the client obd structure and to assign a virtual index (the tag) to
> each modify RPC to help server side cleaning of reply data.
>
> The mdc component uses this feature to send multiple modify RPCs
> in parallel.
>
> Signed-off-by: Gregoire Pichon <gregoire.pichon@xxxxxxxx>
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5319
> Reviewed-on: http://review.whamcloud.com/14374
> Reviewed-by: Andreas Dilger <andreas.dilger@xxxxxxxxx>
> Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@xxxxxxxxx>
> Reviewed-by: Oleg Drokin <oleg.drokin@xxxxxxxxx>
> Signed-off-by: James Simmons <jsimmons@xxxxxxxxxxxxx>
> ---
> drivers/staging/lustre/lustre/fid/fid_request.c | 4 -
> drivers/staging/lustre/lustre/include/lustre_mdc.h | 24 +++
> drivers/staging/lustre/lustre/include/obd.h | 7 +-
> drivers/staging/lustre/lustre/include/obd_class.h | 6 +
> drivers/staging/lustre/lustre/ldlm/ldlm_lib.c | 37 +++++
> drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 23 +++
> drivers/staging/lustre/lustre/mdc/mdc_locks.c | 13 +-
> drivers/staging/lustre/lustre/mdc/mdc_reint.c | 23 +--
> drivers/staging/lustre/lustre/mdc/mdc_request.c | 50 ++-----
> drivers/staging/lustre/lustre/obdclass/genops.c | 171 +++++++++++++++++++-
> 10 files changed, 293 insertions(+), 65 deletions(-)

What changed from v1 of this patch? You always need to put that below
the --- line so we can remember what is going on here...

Can you make a v3 with that information please?

thanks,

greg k-h