Re: [PATCH v4] media: et8ek8: add device tree binding documentation

[Pavel Machek]

On Fri 2016-11-04 00:20:14, Sakari Ailus wrote:
> Hi Pavel and Rob,
> 
> On Thu, Nov 03, 2016 at 01:47:49PM +0100, Pavel Machek wrote:
> > Hi!
> > 
> > > > +Mandatory properties
> > > > +--------------------
> > > > +
> > > > +- compatible: "toshiba,et8ek8"
> > > > +- reg: I2C address (0x3e, or an alternative address)
> > > > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts
> > > > +- clocks: External clock to the sensor
> > > > +- clock-frequency: Frequency of the external clock to the sensor. Camera
> > > > +  driver will set this frequency on the external clock.
> > > 
> > > This is fine if the frequency is fixed (e.g. an oscillator), but you 
> > > should use the clock binding if clocks are programable.
> > 
> > It is fixed. So I assume this can stay as is? Or do you want me to add
> > "The clock frequency is a pre-determined frequency known to be
> > suitable to the board." as Sakari suggests?

Rob?
								Pavel

> > > > +- reset-gpios: XSHUTDOWN GPIO
> > > 
> > > Please state what the active polarity is.
> > 
> > As in "This gpio will be set to 1 when the chip is powered." ?
> 
> How about:
> 
> "The XSHUTDOWN signal is active high. The sensor is in hardware standby
> mode when the signal is in low state."
> 
> These bindings start looking more precise than the smiapp ones. :-)
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature