Re: [PATCH 04/14] staging/lustre/llite: clear inode timestamps after losing UPDATE lock

From: James Simmons
Date: Sun Nov 06 2016 - 20:38:21 EST



> From: Niu Yawei <yawei.niu@xxxxxxxxx>
>
> Otherwise, those leftovers would interfere with new timestamps
> especially when the timestamps are set back in time on the other
> clients.

Reviewed-by: James Simmons <jsimmons@xxxxxxxxxxxxx>

> Signed-off-by: Jinshan Xiong <jinshan.xiong@xxxxxxxxx>
> Signed-off-by: Niu Yawei <yawei.niu@xxxxxxxxx>
> Reviewed-on: http://review.whamcloud.com/22623
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8446
> Reviewed-by: Bobi Jam <bobijam@xxxxxxxxxxx>
> Signed-off-by: Oleg Drokin <green@xxxxxxxxxxxxxx>
> ---
> drivers/staging/lustre/lustre/llite/namei.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/staging/lustre/lustre/llite/namei.c b/drivers/staging/lustre/lustre/llite/namei.c
> index 74d9b73..c268f32 100644
> --- a/drivers/staging/lustre/lustre/llite/namei.c
> +++ b/drivers/staging/lustre/lustre/llite/namei.c
> @@ -251,6 +251,16 @@ int ll_md_blocking_ast(struct ldlm_lock *lock, struct ldlm_lock_desc *desc,
> PFID(ll_inode2fid(inode)), rc);
> }
>
> + if (bits & MDS_INODELOCK_UPDATE) {
> + struct ll_inode_info *lli = ll_i2info(inode);
> +
> + spin_lock(&lli->lli_lock);
> + LTIME_S(inode->i_mtime) = 0;
> + LTIME_S(inode->i_atime) = 0;
> + LTIME_S(inode->i_ctime) = 0;
> + spin_unlock(&lli->lli_lock);
> + }
> +
> if ((bits & MDS_INODELOCK_UPDATE) && S_ISDIR(inode->i_mode)) {
> struct ll_inode_info *lli = ll_i2info(inode);
>
> --
> 2.7.4
>
>