Re: [PATCH 13/22] mtd: nand: lpc32xx: return error code of nand_scan_ident/tail() on error

[Vladimir Zapolskiy]

Hi Boris,

On 11/06/2016 08:27 PM, Boris Brezillon wrote:
> On Fri,  4 Nov 2016 19:43:01 +0900
> Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote:
>
> > The nand_scan_ident/tail() returns an appropriate error value when
> > it fails.  Use it instead of the fixed error code -ENXIO.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> > ---

[snip]

> > -	if (nand_scan_tail(mtd)) {
> > -		res = -ENXIO;
> > +	res = nand_scan_tail(mtd);
>
> You miss
>
> 	if (res)
>
> here.
>
> No need to resend, I'll fix it when applying the patches.
>
> >  		goto err_exit3;
> > -	}

nice catch, thank you for noticing and fixing the overlooked bug!

--
With best wishes,
Vladimir