Re: [PATCH] mtd: nand: denali_dt: replace clk_disable() with clk_disable_unprepare()

From: Boris Brezillon
Date: Sun Nov 06 2016 - 17:56:45 EST


On Thu, 3 Nov 2016 02:21:04 +0900
Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote:

> The denali_dt_probe() calls clk_disable_unprepare() in the bailout
> path, whereas denali_dt_remove calls clk_disable(), inconsistently.
> Replace the latter with clk_disable_unprepare() to make sure to
> unprepare the clock.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>

Applied.

Thanks,

Boris

> ---
>
> drivers/mtd/nand/denali_dt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c
> index 0cb1e8d..f821dc1 100644
> --- a/drivers/mtd/nand/denali_dt.c
> +++ b/drivers/mtd/nand/denali_dt.c
> @@ -110,7 +110,7 @@ static int denali_dt_remove(struct platform_device *ofdev)
> struct denali_dt *dt = platform_get_drvdata(ofdev);
>
> denali_remove(&dt->denali);
> - clk_disable(dt->clk);
> + clk_disable_unprepare(dt->clk);
>
> return 0;
> }