Re: [PATCH V2 2/2] blk-mq: immediately dispatch big size request

From: Jens Axboe
Date: Fri Nov 04 2016 - 11:29:51 EST


On 11/04/2016 08:46 AM, Christoph Hellwig wrote:
On Thu, Nov 03, 2016 at 10:00:58PM -0600, Jens Axboe wrote:
I've applied 1-2 for 4.10, but we probably should look into unifying
those parts of sq and mq in general. For instance, it doesn't seem to
make a lot of sense why we'd depth limit sq and not mq.

I've spent some time looking the the make_request_fn and to be honest
I think that whole sq vs mq split is pointless. They are about 70-80%
the same anyway, and I think everyone would be served much better
by merging them.

Yeah, that was my point, at least if we can do it without having too
many extra conditionals. Or at least split some of it into helpers.

--
Jens Axboe