Re: [PATCH] swapfile: fix memory corruption via malformed swapfile

From: Johannes Weiner
Date: Fri Nov 04 2016 - 10:57:33 EST


On Mon, Oct 31, 2016 at 10:32:13PM +0100, Jann Horn wrote:
> When root activates a swap partition whose header has the wrong endianness,
> nr_badpages elements of badpages are swabbed before nr_badpages has been
> checked, leading to a buffer overrun of up to 8GB.
>
> This normally is not a security issue because it can only be exploited by
> root (more specifically, a process with CAP_SYS_ADMIN or the ability to
> modify a swap file/partition), and such a process can already e.g. modify
> swapped-out memory of any other userspace process on the system.
>
> Testcase for reproducing the bug (must be run as root, should crash your
> kernel):
[...]
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Jann Horn <jann@xxxxxxxxx>

Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>