Re: [PATH] z3fold: extend compaction function

From: Andrew Morton
Date: Thu Nov 03 2016 - 17:16:13 EST


On Thu, 3 Nov 2016 22:04:28 +0100 Vitaly Wool <vitalywool@xxxxxxxxx> wrote:

> z3fold_compact_page() currently only handles the situation when
> there's a single middle chunk within the z3fold page. However it
> may be worth it to move middle chunk closer to either first or
> last chunk, whichever is there, if the gap between them is big
> enough.

"may be worth it" is vague. Does the patch improve the driver or does
it not? If it *does* improve the driver then in what way? *Why* is is
"worth it"?

> This patch adds the relevant code, using BIG_CHUNK_GAP define as
> a threshold for middle chunk to be worth moving.