Re: [PATCH 9/9] clocksource: import ARC timer driver

From: Daniel Lezcano
Date: Thu Nov 03 2016 - 14:16:18 EST


On Thu, Nov 03, 2016 at 06:33:17PM +0100, Daniel Lezcano wrote:

[ ... ]

> As now the clksrc-probe is correctly handling the errors, if the rtc and the
> gfrc are both defined in the DT, you can fail to init the rtc one with a simple
> test in the init function:
>
> if (IS_DEFINED(CONFIG_SMP))
> return -EINVAL;
>
> So, you can inconditionaly compile in both RTC and GFRC, no ? That would be
> cleaner and prevent a different kernel config.

Ah, actually I suggested something which is already there :)

Perhaps, the if SMP does not make sense in the Kconfig, no ?