Re: [PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry

From: Jon Mason
Date: Tue Nov 01 2016 - 16:00:24 EST


On Tue, Nov 01, 2016 at 07:46:39PM +0100, Andrew Lunn wrote:
> Hi Jon
>
> > @@ -56,6 +57,8 @@
> > #define PHY_BRCM_EXT_IBND_TX_ENABLE 0x00002000
> > #define PHY_BRCM_CLEAR_RGMII_MODE 0x00004000
> > #define PHY_BRCM_DIS_TXCRXC_NOENRGY 0x00008000
> > +#define PHY_BRCM_EXP_LANE_SWAP 0x00010000
> > +
>
> You define this, but don't use it...

Good catch. Cruft from the last patch. I'll sendout a quick v4 to
address this and the missing Documentation patch.

>
> Andrew