Re: [PATCH v3] ARM: bcm2835: Add names for the Raspberry Pi GPIO lines

From: Eric Anholt
Date: Tue Nov 01 2016 - 12:16:33 EST


Stefan Wahren <stefan.wahren@xxxxxxxx> writes:

>> Eric Anholt <eric@xxxxxxxxxx> hat am 31. Oktober 2016 um 18:53 geschrieben:
>>
>>
>> Stefan Wahren <stefan.wahren@xxxxxxxx> writes:
>>
>> > Hi Eric,
>> >
>> >> Eric Anholt <eric@xxxxxxxxxx> hat am 27. Oktober 2016 um 18:52 geschrieben:
>> >>
>> >>
>> >> From: Linus Walleij <linus.walleij@xxxxxxxxxx>
>> >>
>> >> The idea is to give useful names to GPIO lines that an implementer
>> >> will be using from userspace, e.g. for maker type projects. These are
>> >> user-visible using tools/gpio/lsgpio.c
>> >
>> > sorry for the late feedback, but did you check your patch against the
>> > Firmware
>> > DTS [1]?
>> >
>> > As an example the GPIO38 is connected and named as USB_LIMIT_1A2 since
>> > Raspberry
>> > Pi 1 B Plus.
>> >
>> > [1] -
>> > https://github.com/raspberrypi/documentation/blob/master/configuration/images/dt-blob.dts
>>
>> I did use the dt-blob sometimes for cross-checking, but these are
>> written against the schematics, not the dt-blob. If you've got things
>> you'd like changed, could you send a patch?
>
> A patch against your v3 or my own v4 based on your patch?

A followon patch is great, then the changes are obvious and we can
either squash or commit as appropriate.

Attachment: signature.asc
Description: PGP signature