Re: [PATCHv2] PCI: QDF2432 32 bit config space accessors

From: cov
Date: Tue Nov 01 2016 - 09:07:13 EST


Hi Bjorn,

On 2016-10-31 15:48, Bjorn Helgaas wrote:
On Wed, Sep 21, 2016 at 06:38:05PM -0400, Christopher Covington wrote:
The Qualcomm Technologies QDF2432 SoC does not support accesses smaller
than 32 bits to the PCI configuration space. Register the appropriate
quirk.

Signed-off-by: Christopher Covington <cov@xxxxxxxxxxxxxx>

Hi Christopher,

Can you rebase this against v4.9-rc1? It no longer applies to my tree.

I apologize for not being clearer. This patch depends on:

PCI/ACPI: Extend pci_mcfg_lookup() responsibilities
PCI/ACPI: Check platform-specific ECAM quirks

These patches from Tomasz Nowicki were previously in your pci/ecam-v6
branch, but that seems to have come and gone. How would you like to
proceed?

Note that this hardware is not spec-compliant since it doesn't support
sub-32 bit config writes. I just proposed a patch to warn about that
[1], so if/when we merge that patch and this one, you'll start seeing
those warnings.

[1]
http://lkml.kernel.org/r/20161031213902.6340.96123.stgit@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

That looks great, thank you. The earlier PCI HDL and SoC vendors can be
made aware of such problems, the better.

Thanks,
Cov