Re: [PATCH v2 3/4] arm64: dts: msm8996: Add SMEM DT nodes

[Sarangdhar Joshi]

On 10/20/2016 05:04 PM, Stephen Boyd wrote:
> On 10/20, Sarangdhar Joshi wrote:
> > From: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> >
> > Add SMEM and TCSR DT nodes on MSM8996.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > Signed-off-by: Sarangdhar Joshi <spjoshi@xxxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > index 949b096..abc1089 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > @@ -164,17 +164,36 @@
> >
> >  	};
> >
> > +	tcsr_mutex: hwlock {
> > +		compatible = "qcom,tcsr-mutex";
> > +		syscon = <&tcsr_mutex_regs 0 0x1000>;
> > +		#hwlock-cells = <1>;
> > +	};
> > +
> >  	psci {
> >  		compatible = "arm,psci-1.0";
> >  		method = "smc";
> >  	};
> >
> > +	smem {
> > +		compatible = "qcom,smem";
> > +
> > +		memory-region = <&smem_mem>;
> > +
> > +		hwlocks = <&tcsr_mutex 3>;
>
> Super nitpick: Is there a reason we have newlines between
> everything in this node? This node is the only one that isn't
> consistent.

Thanks, will do that. I think I just missed updating this node from 
original patchset.

>


--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project