Re: [PATCH] x86/AMD: Apply erratum 688 on machines without a BIOS fix

From: sonofagun
Date: Fri Oct 21 2016 - 12:19:27 EST



Sorry for the late reply! This machine has caused nothing but trouble. HP will not fix it and we will not choose their laptops anymore...

My brother told me that we apply a quirk to the last Ontario APUs that do not need it but I did not think it would be an issue since they have fixed the error.
It seems better this way so that only affected APUs are patched. Be patient, we are compiling the new patch right now but compiling is run on a different high end AMD machine of my brother. Tomorrow I will have access to the laptop and I will update the kernel and send you the V2 patch. Compiling to that laptop would possibly need a whole day even with AC power!


Do you want /proc/cpuinfo on the V2 patch e-mail? Both CPUs needed?
Here is a dump from an older installation some months ago I kept on my disk(tomorrow I will dump it again if you want):
processor : 0
vendor_id : AuthenticAMD
cpu family : 20
model : 2
model name : AMD E-300 APU with Radeon(tm) HD Graphics
stepping : 0
microcode : 0x5000119
cpu MHz : 1300.000
cache size : 512 KB
physical id : 0
siblings : 2
core id : 0
cpu cores : 2
apicid : 0
initial apicid : 0
fpu : yes
fpu_exception : yes
cpuid level : 6
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc extd_apicid aperfmperf pni monitor ssse3 cx16 popcnt lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch ibs skinit wdt hw_pstate vmmcall arat npt lbrv svm_lock nrip_save pausefilter
bugs : fxsave_leak sysret_ss_attrs
bogomips : 2594.69
TLB size : 1024 4K pages
clflush size : 64
cache_alignment : 64
address sizes : 36 bits physical, 48 bits virtual
power management: ts ttp tm stc 100mhzsteps hwpstate

processor : 1
vendor_id : AuthenticAMD
cpu family : 20
model : 2
model name : AMD E-300 APU with Radeon(tm) HD Graphics
stepping : 0
microcode : 0x5000119
cpu MHz : 1300.000
cache size : 512 KB
physical id : 0
siblings : 2
core id : 1
cpu cores : 2
apicid : 1
initial apicid : 1
fpu : yes
fpu_exception : yes
cpuid level : 6
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc extd_apicid aperfmperf pni monitor ssse3 cx16 popcnt lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch ibs skinit wdt hw_pstate vmmcall arat npt lbrv svm_lock nrip_save pausefilter
bugs : fxsave_leak sysret_ss_attrs
bogomips : 2594.69
TLB size : 1024 4K pages
clflush size : 64
cache_alignment : 64
address sizes : 36 bits physical, 48 bits virtual
power management: ts ttp tm stc 100mhzsteps hwpstate


Then, keep that *whole* changelog above when sending v2 of the patch
What do you mean? It is not clear to me, Do you mean all the info we wrote on the e-mail, your comments or both?

We have many AMD machines and we will need your help next week to patch our Phenom(tm) II X6. Let's finish this
patch first and we will fix that too but it appears to be much more difficult...