RE: [PATCH net-next v2 6/9] net: use core MTU range checking in virt drivers

From: Kershner, David A
Date: Thu Oct 20 2016 - 16:46:28 EST




> -----Original Message-----
> From: Haiyang Zhang [mailto:haiyangz@xxxxxxxxxxxxx]
> Sent: Thursday, October 20, 2016 2:05 PM
> To: Jarod Wilson <jarod@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx; KY
> Srinivasan <kys@xxxxxxxxxxxxx>; Michael S. Tsirkin <mst@xxxxxxxxxx>;
> Shrikrishna Khare <skhare@xxxxxxxxxx>; VMware, Inc. <pv-
> drivers@xxxxxxxxxx>; Wei Liu <wei.liu2@xxxxxxxxxx>; Paul Durrant
> <paul.durrant@xxxxxxxxxx>; Kershner, David A
> <David.Kershner@xxxxxxxxxx>
> Subject: RE: [PATCH net-next v2 6/9] net: use core MTU range checking in virt
> drivers
>
>
>
> > -----Original Message-----
> > From: Jarod Wilson [mailto:jarod@xxxxxxxxxx]
> > Sent: Thursday, October 20, 2016 1:55 PM
> > To: linux-kernel@xxxxxxxxxxxxxxx
> > Cc: Jarod Wilson <jarod@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> > virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx; KY Srinivasan
> > <kys@xxxxxxxxxxxxx>; Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>;
> Michael S.
> > Tsirkin <mst@xxxxxxxxxx>; Shrikrishna Khare <skhare@xxxxxxxxxx>;
> VMware,
> > Inc. <pv-drivers@xxxxxxxxxx>; Wei Liu <wei.liu2@xxxxxxxxxx>; Paul
> > Durrant <paul.durrant@xxxxxxxxxx>; David Kershner
> > <david.kershner@xxxxxxxxxx>
> > Subject: [PATCH net-next v2 6/9] net: use core MTU range checking in
> > virt drivers
> >
> > hyperv_net:
> > - set min/max_mtu, per Haiyang, after rndis_filter_device_add
> >
> > virtio_net:
> > - set min/max_mtu
> > - remove virtnet_change_mtu
> >
> > vmxnet3:
> > - set min/max_mtu
> >
> > xen-netback:
> > - min_mtu = 0, max_mtu = 65517
> >
> > xen-netfront:
> > - min_mtu = 0, max_mtu = 65535
> >
> > unisys/visor:
> > - clean up defines a little to not clash with network core or add
> > redundat definitions
> >
> > CC: netdev@xxxxxxxxxxxxxxx
> > CC: virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
> > CC: "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>
> > CC: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> > CC: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
> > CC: Shrikrishna Khare <skhare@xxxxxxxxxx>
> > CC: "VMware, Inc." <pv-drivers@xxxxxxxxxx>
> > CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> > CC: Paul Durrant <paul.durrant@xxxxxxxxxx>
> > CC: David Kershner <david.kershner@xxxxxxxxxx>
> > Signed-off-by: Jarod Wilson <jarod@xxxxxxxxxx>
> > ---
>
> The hv_netvsc changes look fine. Thanks.
>
> Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
>

The visornic changes look good.

Reviewed-by: David Kershner <david.kershner@xxxxxxxxxx>