Re: [PATCH v2 4/4] ACPI / gpio: Allow holes in list of GPIOs for a device

From: Linus Walleij
Date: Thu Oct 20 2016 - 08:10:59 EST


On Thu, Sep 29, 2016 at 3:39 PM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:

> Make it possible to have an empty GPIOs in a GPIO list for device. For
> example a SPI master may use both GPIOs and native pins as chip selects and
> we need to be able to distinguish between the two.
>
> This makes it mandatory to have exactly 3 arguments for GPIOs and then
> converts gpiolib to use of __acpi_node_get_property_reference() instead. In
> addition we make acpi_gpio_package_count() to handle holes as well (this
> matches the DT version).
>
> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Looks OK.

Do I need someone's ACK to merge stuff under
Documentation/acpi/gpio-properties.txt?
Like Rafael?

Yours,
Linus Walleij