Re: [RESEND][PATCHv2] cpupower: Correct return type of cpu_power_is_cpu_online in cpufreq

From: Shilpasri G Bhat
Date: Thu Oct 20 2016 - 04:13:08 EST




On 10/20/2016 04:23 AM, Laura Abbott wrote:
> When converting to a shared library in ac5a181d065d ("cpupower: Add
> cpuidle parts into library"), cpu_freq_cpu_exists was converted to
> cpupower_is_cpu_online. cpu_req_cpu_exists returned 0 on success and
> -ENOSYS on failure whereas cpupower_is_cpu_online returns 1 on success.
> Check for the correct return value in cpufreq-set.
>
> See https://bugzilla.redhat.com/show_bug.cgi?id=1374212
>
> Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
> Reported-by: Julian Seward <jseward@xxxxxxx>
> Signed-off-by: Laura Abbott <labbott@xxxxxxxxxx>
> ---
> v2: Drop another redundant cpupower_is_cpu_online

Reviewed-by:Shilpasri G Bhat <shilpa.bhat@xxxxxxxxxxxxxxxxxx>