Re: [media] winbond-cir: Move assignments for three variables in wbcir_shutdown()

From: David HÃrdeman
Date: Wed Oct 19 2016 - 11:49:05 EST


October 19, 2016 3:38 PM, "SF Markus Elfring" <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
>>> Move the setting for the local variables "mask", "match" and "rc6_csl"
>>> behind the source code for a condition check by this function
>>> at the beginning.
>>
>> Again, I can't see what the point is?
>
> * How do you think about to set these variables only after the initial
> check succeded?

I prefer setting variables early so that no thinking about whether they're initialized or not is necessary later.

> * Do you care for data access locality?

Not unless you can show measurable performance improvements?