Re: [v4.8-rc1 Regression] sched/fair: Apply more PELT fixes

From: Vincent Guittot
Date: Wed Oct 19 2016 - 10:39:52 EST


On 19 October 2016 at 13:33, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Tue, Oct 18, 2016 at 01:56:51PM +0200, Vincent Guittot wrote:
>
>> ---
>> kernel/sched/fair.c | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index 8b03fb5..89776ac 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -690,7 +690,14 @@ void init_entity_runnable_average(struct sched_entity *se)
>> * will definitely be update (after enqueue).
>> */
>> sa->period_contrib = 1023;
>> - sa->load_avg = scale_load_down(se->load.weight);
>> + /*
>> + * Tasks are intialized with full load to be seen as heavy task until
>> + * they get a chance to stabilize to their real load level.
>> + * group entity are intialized with null load to reflect the fact that
>> + * nothing has been attached yet to the task group.
>> + */
>> + if (entity_is_task(se))
>> + sa->load_avg = scale_load_down(se->load.weight);
>> sa->load_sum = sa->load_avg * LOAD_AVG_MAX;
>> /*
>> * At this point, util_avg won't be used in select_task_rq_fair anyway
>>
>
> Vince, could you post a proper version of this patch with changelogs and
> tags so that we can get that merged into Linus' tree and stable for 4.8?

yes. i just have to finish the changelog and i sent it

>