Re: [media] winbond-cir: Move a variable assignment in wbcir_tx()

From: David HÃrdeman
Date: Wed Oct 19 2016 - 10:27:12 EST


October 19, 2016 3:32 PM, "SF Markus Elfring" <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
>>> Move the assignment for the local variable "data" behind the source code
>>> for a memory allocation by this function.
>>
>> Sorry, I can't see what the point is?
>
> * How do you think about to avoid a variable assignment in case
> that this memory allocation failed anyhow?

There is no memory allocation that can fail at this point.

> * Do you care for data access locality?

Not unless you can show measurable performance improvements?