Re: [PATCH] checkpatch: don't try to get maintained status when --no-tree is given

From: Joe Perches
Date: Mon Oct 17 2016 - 13:03:29 EST


On Mon, 2016-10-17 at 17:55 +0200, Jerome Forissier wrote:
> Fixes the following warning:
> Use of uninitialized value $root in concatenation (.) or string at /path/to/checkpatch.pl line 764.

Thanks Jerome.

> Signed-off-by: Jerome Forissier <jerome.forissier@xxxxxxxxxx>

Acked-by: Joe Perches <joe@xxxxxxxxxxx>

> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a8368d1..aa694bc 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -761,7 +761,7 @@ sub seed_camelcase_file {
> sub is_maintained_obsolete {
> my ($filename) = @_;
>
> - return 0 if (!(-e "$root/scripts/get_maintainer.pl"));
> + return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
>
> my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;