Re: [patch ]mm/zs_malloc: Fix bit spinlock replacement

From: Sebastian Andrzej Siewior
Date: Mon Oct 17 2016 - 11:15:49 EST


On 2016-10-16 05:18:03 [+0200], Mike Galbraith wrote:
>
> Do not alter HANDLE_SIZE, memory corruption ensues. The handle is
> a pointer, allocate space for the struct it points to and align it
> ZS_ALIGN. Also, when accessing the struct, mask HANDLE_PIN_BIT.

So this is to merged / folded into "mm/zsmalloc: Use get/put_cpu_light
in zs_map_object()/zs_unmap_object()" which I re-did for v4.8?
How was this tested?
I have:
CONFIG_FRONTSWAP=y
# CONFIG_CMA is not set
CONFIG_ZSWAP=y
CONFIG_ZPOOL=y
CONFIG_ZBUD=m
CONFIG_Z3FOLD=m
CONFIG_ZSMALLOC=m
# CONFIG_PGTABLE_MAPPING is not set
CONFIG_ZSMALLOC_STAT=y

and

# cat /sys/module/zswap/parameters/enabled
Y
cat /sys/module/zswap/parameters/zpool
zbud
# cat /sys/module/zswap/parameters/compressor
lzo
# cat /sys/module/zswap/parameters/max_pool_percent
20

and I do have 1GiB of swap on /dev/vdc. While I get swap to be used, I
see no firework. Is there something wrong with my setup? I would assume
so due to the lack of the fireworks on my sideâ

> Signed-off-by: Mike Galbraith <umgwanakikbuti@xxxxxxxxx>

Sebastian