Re: [PATCH] kasan: support panic_on_warn

From: Andrey Ryabinin
Date: Mon Oct 17 2016 - 07:33:30 EST




On 10/17/2016 11:57 AM, Dmitry Vyukov wrote:
> If user sets panic_on_warn, he wants kernel to panic if there is
> anything barely wrong with the kernel. KASAN-detected errors
> are definitely not less benign than an arbitrary kernel WARNING.
>
> Panic after KASAN errors if panic_on_warn is set.
>
> We use this for continuous fuzzing where we want kernel to stop
> and reboot on any error.
>
> Signed-off-by: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
> Cc: kasan-dev@xxxxxxxxxxxxxxxx
> Cc: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
> Cc: Alexander Potapenko <glider@xxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: linux-mm@xxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
>

Acked-by: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
> ---
>
> Changes from v1:
> - don't reset panic_on_warn before calling panic()
> ---
> mm/kasan/report.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mm/kasan/report.c b/mm/kasan/report.c
> index 24c1211..0ee8211 100644
> --- a/mm/kasan/report.c
> +++ b/mm/kasan/report.c
> @@ -133,6 +133,8 @@ static void kasan_end_report(unsigned long *flags)
> pr_err("==================================================================\n");
> add_taint(TAINT_BAD_PAGE, LOCKDEP_NOW_UNRELIABLE);
> spin_unlock_irqrestore(&report_lock, *flags);
> + if (panic_on_warn)
> + panic("panic_on_warn set ...\n");
> kasan_enable_current();
> }
>
>