Re: [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx

From: Sylvain Rochet
Date: Sun Oct 16 2016 - 13:12:08 EST


Hi Peter,

On Sun, Oct 16, 2016 at 12:57:09PM +0200, Peter Rosin wrote:
> Hi again,
>
> I forgot about this, and it's been a year. But isn't it time to
> upstream those pull-up fixes that Sylvain provided?

Thank you for your reminder, actually I waited an answer on this nice
subject: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/368643.html

But this is not relevant for this change anyway, if we should set a
pull-(up|down) on all push-pull pads to reduce power consumption it
should be enforced in the pinctrl driver, the dt must stay logical.

I just sent a v2 with all useless comments removed as suggested by
Alexandre and without the explanation about the removed extra power
consumption when removing a pull-(up|down) on a push-pull output because
it does even seem to be the contrary on Atmel SoCs.

Sylvain