Re: [PATCH 02/10] perf, tools: Only print Using CPUID message once

From: Arnaldo Carvalho de Melo
Date: Fri Oct 14 2016 - 11:45:55 EST


Em Thu, Oct 13, 2016 at 02:15:24PM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
> With uncore event aliases which are duplicated over multiple PMUs
> the "Using CPUID" message with -v could be printed many times.
> Only print it once.

Thanks, applied.

- Arnaldo

> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> ---
> tools/perf/util/pmu.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 9adae7e7477c..b36bf9e77799 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -508,6 +508,7 @@ static void pmu_add_cpu_aliases(struct list_head *head)
> struct pmu_events_map *map;
> struct pmu_event *pe;
> char *cpuid;
> + static bool printed;
>
> cpuid = getenv("PERF_CPUID");
> if (cpuid)
> @@ -517,7 +518,10 @@ static void pmu_add_cpu_aliases(struct list_head *head)
> if (!cpuid)
> return;
>
> - pr_debug("Using CPUID %s\n", cpuid);
> + if (!printed) {
> + pr_debug("Using CPUID %s\n", cpuid);
> + printed = true;
> + }
>
> i = 0;
> while (1) {
> --
> 2.5.5