Re: [PATCH] cpufreq: intel_pstate: Add Knights Mill CPUID

From: Rafael J. Wysocki
Date: Wed Oct 12 2016 - 15:41:13 EST


On Wednesday, October 12, 2016 08:25:50 PM Piotr Luc wrote:
> Add Knights Mill (KNM) to the list of CPUIDs supported by intel_pstate.
>
> Signed-off-by: Piotr Luc <piotr.luc@xxxxxxxxx>
> Reviewed-by: Dave Hansen <dave.hansen@xxxxxxxxx>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> Cc: Len Brown <lenb@xxxxxxxxxx>
> Cc: "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>
> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Cc: linux-pm@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
> Depends-on: x86/cpu/intel: Add Knights Mill to Intel family
> https://lkml.kernel.org/r/20161012180520.30976-1-piotr.luc () intel ! com

First, putting broken URLs into patch tags doesn't really help.

Second, please send all of these patches as a series where the first
patch makes the change the rest depends on. That would make them easier to
handle.

>
> drivers/cpufreq/intel_pstate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index be9eade..4240aff 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1367,6 +1367,7 @@ static const struct x86_cpu_id intel_pstate_cpu_ids[] = {
> ICPU(INTEL_FAM6_SKYLAKE_DESKTOP, core_params),
> ICPU(INTEL_FAM6_BROADWELL_XEON_D, core_params),
> ICPU(INTEL_FAM6_XEON_PHI_KNL, knl_params),
> + ICPU(INTEL_FAM6_XEON_PHI_KNM, knl_params),
> ICPU(INTEL_FAM6_ATOM_GOLDMONT, bxt_params),
> {}
> };
>

Thanks,
Rafael