Re: [PATCH 3.4 027/125] firewire: ohci: fix JMicron JMB38x IT context discovery

From: Stefan Richter
Date: Wed Oct 12 2016 - 09:09:17 EST


On Oct 12 lizf@xxxxxxxxxx wrote:
[...]
> Signed-off-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>
> [lizf: Backported to 3.4: use dev_notice() instead of ohci_notice()]
> Signed-off-by: Zefan Li <lizefan@xxxxxxxxxx>
> ---
> drivers/firewire/ohci.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c
> index c1de4c3..4eedb07 100644
> --- a/drivers/firewire/ohci.c
> +++ b/drivers/firewire/ohci.c
> @@ -3620,6 +3620,11 @@ static int __devinit pci_probe(struct pci_dev *dev,
>
> reg_write(ohci, OHCI1394_IsoXmitIntMaskSet, ~0);
> ohci->it_context_support = reg_read(ohci, OHCI1394_IsoXmitIntMaskSet);
> + /* JMicron JMB38x often shows 0 at first read, just ignore it */
> + if (!ohci->it_context_support) {
> + dev_notice(&dev->dev, "overriding IsoXmitIntMask\n");
> + ohci->it_context_support = 0xf;
> + }
> reg_write(ohci, OHCI1394_IsoXmitIntMaskClear, ~0);
> ohci->it_context_mask = ohci->it_context_support;
> ohci->n_it = hweight32(ohci->it_context_mask);

Backport looks good to me. Thanks.
--
Stefan Richter
-======----- =-=- -==--
http://arcgraph.de/sr/