Re: [PATCH 2/2] jnx: Introduce include/linux/jnx/pci_ids.h

[Greg Kroah-Hartman]

On Fri, Oct 07, 2016 at 06:15:46PM +0300, Pantelis Antoniou wrote:
> From: Rajat Jain <rajatjain@xxxxxxxxxxx>
> 
> Add this header to contain the PCI device IDs that we cannot add in
> the linux pci_ids.h.

Why can't you?

> This would contain PCI device IDs of Juniper devices as well as any
> PCIe switches etc.

Why do you need a .h file for this?  Is the values in it shared across
drivers?  If not, you don't nee a .h file at all.  If so, then it
belongs in pci_ids.h as the top of that file describes.

thanks,

greg k-h