Re: [PATCH] [media] : Removing warnings caught by checkpatch.pl

From: Laurent Pinchart
Date: Tue Oct 04 2016 - 03:59:54 EST


Hi Andrey,

On Monday 03 Oct 2016 22:52:11 Andrey Utkin wrote:
> On Sun, Oct 02, 2016 at 02:30:45AM +0530, Harman Kalra wrote:
> > static int iss_video_queue_setup(struct vb2_queue *vq,
> >
> > - unsigned int *count, unsigned int
*num_planes,
> > - unsigned int sizes[], struct device
*alloc_devs[])
> > + unsigned int *count, unsigned int *num_planes,
> > + unsigned int sizes[], struct device *alloc_devs[])
>
> 2 spaces + 3 tabs -> 2 spaces + 2 tabs? Am I seeing this correctly?
> Both ways are against CodingStyle.

It's 4 tabs + 1 space -> 3 tabs as far as I can see.

> > - /* Try the get selection operation first and fallback to get format if
> > not - * implemented.
> > + /* Try the get selection operation first and
> > + * fallback to get format if not implemented.
> >
> > */
>
> This comment style is discouraged so this is at lease not perfect.
> Doesn't checkpatch complain with this change? If it doesn't, could you
> please also check with --strict, as long as you're working on style.

--
Regards,

Laurent Pinchart