Re: [PATCH] mlxsw: spectrum: remove redundant check if err is zero

From: Jiri Pirko
Date: Fri Sep 23 2016 - 08:15:25 EST


Fri, Sep 23, 2016 at 01:02:45PM CEST, colin.king@xxxxxxxxxxxxx wrote:
>From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
>There is an earlier check and return if err is non-zero, so
>the check to see if it is zero is redundant in every iteration
>of the loop and hence the check can be removed.
>
>Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Acked-by: Jiri Pirko <jiri@xxxxxxxxxxxx>