RE: [PATCH v6 1/9] rpmb: add Replay Protected Memory Block (RPMB) subsystem

From: Avri Altman
Date: Fri Sep 23 2016 - 05:54:35 EST



>
> Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>
Tested-by: Avri Altman <Avri.Altman@xxxxxxxxxxx>

- mmc - full functionality. One issue found that was fixed on V6: patch V6 2/9.
- ufs - read & read counter only. Testing is still wip.


> +static int rpmb_request_verify(struct rpmb_dev *rdev, struct rpmb_data
> +*rpmbd) {

Seems excessive - Isn't the standard should be enforced by the device?

Cheers,
Avri