Re: [PATCH] KVM: VMX: refactor global page-sized bitmaps

[Wanpeng Li]

2016-09-23 17:35 GMT+08:00 Paolo Bonzini <pbonzini@xxxxxxxxxx>:
>
>
> On 23/09/2016 01:18, Radim KrÄmÃÅ wrote:
>> We've had 10 page-sized bitmaps that were being allocated and freed one
>> by one when we could just use a cycle and MSR bitmaps had a lot of
>> useless code lying around.
>>
>> This patch
>>  * enumerates vmx bitmaps and uses an array to store them
>>  * replaces vmx_enable_intercept_msr_read_x2apic() with a condition
>>  * joins vmx_msr_disable_intercept_msr_{read,write}_x2apic()
>>  * renames x2apic_apicv_inactive msr_bitmaps to x2apic and original
>>    x2apic bitmaps to x2apic_apicv
>
> It's almost like this could be split in four patches! :)  Seriously, I
> like it very much but it's very hard to review.

Yeah, I also like it very much. :) I will send a patch for the rename
one, actually it should be in my previous patch, however, a separate
patch is necessary since the previous patch is merged.

Regards,
Wanpeng Li