Re: [PATCH v2 7/7] sched/core: Add debug code to catch missing update_rq_clock()

From: Peter Zijlstra
Date: Thu Sep 22 2016 - 07:22:50 EST


On Thu, Sep 22, 2016 at 11:39:09AM +0200, Peter Zijlstra wrote:
> bit banging the serial port is absolutely awesome, the rest of printk
> not so much.

I also have this second patch that goes on top of this.

I think I had more hacks (like using the per-cpu NMI buffers for output
instead of the on-stack thing), but I cannot seem to find them just now.

---
kernel/printk/printk.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)

--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -356,14 +356,28 @@ static int __init force_early_printk_set
}
early_param("force_early_printk", force_early_printk_setup);

+static int early_printk_cpu = -1;
+
static int early_vprintk(const char *fmt, va_list args)
{
+ int n, cpu, old;
char buf[512];
- int n;
+
+ cpu = get_cpu();
+ for (;;) {
+ old = cmpxchg(&early_printk_cpu, -1, cpu);
+ if (old == -1 || old == cpu)
+ break;
+
+ cpu_relax();
+ }

n = vscnprintf(buf, sizeof(buf), fmt, args);
early_console->write(early_console, buf, n);

+ smp_store_release(&early_printk_cpu, old);
+ put_cpu();
+
return n;
}