Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static

From: Gustavo Padovan
Date: Tue Sep 20 2016 - 07:13:49 EST


2016-09-18 Baoyou Xie <baoyou.xie@xxxxxxxxxx>:

> We get 1 warning when building kernel with W=1:
> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>
> ---
> drivers/dma-buf/sw_sync.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for finding this.

Reviewed-by: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx>

Gustavo