Re: [PATCH 05/14] blk-mq: Remove a redundant assignment

From: Omar Sandoval
Date: Mon Sep 19 2016 - 14:38:32 EST


On Sun, Sep 18, 2016 at 09:37:15AM +0200, Alexander Gordeev wrote:
> blk_mq_hw_ctx::queue_num is initialized in blk_mq_init_hctx()
> function.
>
> CC: linux-block@xxxxxxxxxxxxxxx
> Signed-off-by: Alexander Gordeev <agordeev@xxxxxxxxxx>

Reviewed-by: Omar Sandoval <osandov@xxxxxx>

> ---
> block/blk-mq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 2c77b68..a38fd2e 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -2013,7 +2013,6 @@ static void blk_mq_realloc_hw_ctxs(struct blk_mq_tag_set *set,
>
> atomic_set(&hctxs[i]->nr_active, 0);
> hctxs[i]->numa_node = node;
> - hctxs[i]->queue_num = i;
>
> if (blk_mq_init_hctx(q, set, hctxs[i], i)) {
> free_cpumask_var(hctxs[i]->cpumask);
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-block" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Omar