Re: [PATCH 1/1] ARM: imx5: Add clocks configuration

[Fabien Lahoudere]

Hi,

On 18/09/16 02:24, Shawn Guo wrote:
> On Sun, Sep 18, 2016 at 08:21:59AM +0800, Shawn Guo wrote:
> > On Thu, Sep 15, 2016 at 08:42:33PM +0300, Alexander Shiyan wrote:
> > > > ÐÐÑÐÐÑÐ, 15 ÑÐÐÑÑÐÑÑ 2016, 13:13 +03:00 ÐÑ Fabien Lahoudere <fabien.lahoudere@xxxxxxxxxxxxxxx>:
> > > >
> > > > From: Kalle Kankare < kalle.kankare@xxxxxxxxx >
> > > >
> > > > Add clocks configuration for CSI, FIRI and IEEE1588.
> > > >
> > > > Signed-off-by: Fabien Lahoudere < fabien.lahoudere@xxxxxxxxxxxxxxx >
> > > > ---
> > > >  drivers/clk/imx/clk-imx51-imx53.c      | 20 ++++++++++++++++++++
> > > >  include/dt-bindings/clock/imx5-clock.h | 15 ++++++++++++++-
> > > >  2 files changed, 34 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/clk/imx/clk-imx51-imx53.c b/drivers/clk/imx/clk-imx51-imx53.c
> > > > index 29d4c44..1e3c9ea 100644
> > > > --- a/drivers/clk/imx/clk-imx51-imx53.c
> > > > +++ b/drivers/clk/imx/clk-imx51-imx53.c
> > > > @@ -126,6 +126,7 @@ static const char *spdif0_com_sel[] = { "spdif0_podf", "ssi1_root_gate", };
> > > >  static const char *mx51_spdif1_com_sel[] = { "spdif1_podf", "ssi2_root_gate", };
> > > >  static const char *step_sels[] = { "lp_apm", };
> > > >  static const char *cpu_podf_sels[] = { "pll1_sw", "step_sel" };
> > > > +static const char *ieee1588_sels[] = { "pll3_sw", "pll4_sw", "dummy" /* usbphy2_clk */, "dummy" /* fec_phy_clk */ };
> > > >
> > > >  static struct clk *clk[IMX5_CLK_END];
> > > >  static struct clk_onecell_data clk_data;
> > > > @@ -543,6 +544,25 @@ static void __init mx53_clocks_init(struct device_node *np)
> > > ...
> > >
> > > 2 Shawn Guo: Since the change affects only on i.MX53 architecture,
> > > I would ask to change the subject to i.MX53 if it possible.
> >
> > Yes.  Actually, since clock driver is not moved to drivers/clk, we
>
> s/not/now
>
> > shouldn't prefix it with "ARM: " any longer.


Ok is "clk: imx53: Add clocks configuration" ok?

> Shawn

Thanks

Fabien