Re: [PATCH -next] drm/i915: Fix non static symbol warning

From: Jani Nikula
Date: Mon Sep 19 2016 - 02:33:14 EST


On Sat, 17 Sep 2016, Wei Yongjun <weiyj.lk@xxxxxxxxx> wrote:
> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>
> Fixes the following sparse warning:
>
> drivers/gpu/drm/i915/intel_dp.c:1527:5: warning:
> symbol 'intel_dp_compute_bpp' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 69cee9b..acd0c51 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1524,8 +1524,8 @@ void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock,
> }
> }
>
> -int intel_dp_compute_bpp(struct intel_dp *intel_dp,
> - struct intel_crtc_state *pipe_config)
> +static int intel_dp_compute_bpp(struct intel_dp *intel_dp,
> + struct intel_crtc_state *pipe_config)

Already fixed upstream.

BR,
Jani.


--
Jani Nikula, Intel Open Source Technology Center